Unify Log4j2 appender tests #14859
Merged
Unify Log4j2 appender tests #14859
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
🔧 The result from spotlessApply was committed to the PR branch. |
trask
commented
Oct 1, 2025
There was a problem hiding this comment.
these tests were moved to the shared testing base class
There was a problem hiding this comment.
these tests were mostly redundant with the javaagent tests which were moved to the new shared base class
| } | ||
|
|
||
| @Test | ||
| void logWithSpan() { // Does not work for log replay, but it is not likely to occur because |
There was a problem hiding this comment.
redundant with the new shared base class tests
| <OpenTelemetry name="OpenTelemetryAppender" numLogsCapturedBeforeOtelInstall="1" captureMapMessageAttributes="true" captureMarkerAttribute="true" captureContextDataAttributes="key1,key2" captureExperimentalAttributes="true" captureCodeAttributes="true"/> | ||
| </Appenders> | ||
| <Loggers> | ||
| <Logger name="TestLogger" level="All"> |
There was a problem hiding this comment.
TestLogger is still used by library tests which were not redundant with common tests
|
🔧 The result from spotlessApply was committed to the PR branch. |
trask
force-pushed
the
unify-log4j2-appender-tests
branch
from
679f376 to
5b21e7f
Compare
trask
commented
Oct 3, 2025
.../src/main/java/io/opentelemetry/instrumentation/log4j/appender/v2_17/AbstractLog4j2Test.java
Outdated
Show resolved
Hide resolved
jaydeluca
reviewed
Oct 3, 2025
.../src/main/java/io/opentelemetry/instrumentation/log4j/appender/v2_17/AbstractLog4j2Test.java
Outdated
Show resolved
Hide resolved
13 tasks
trask
force-pushed
the
unify-log4j2-appender-tests
branch
from
3f45b8b to
e9cf224
Compare
trask
force-pushed
the
unify-log4j2-appender-tests
branch
2 times, most recently
from
e60b07a to
227205c
Compare
trask
force-pushed
the
unify-log4j2-appender-tests
branch
2 times, most recently
from
ccd8ecc to
41fbe1f
Compare
trask
commented
Oct 8, 2025
| void testContextData() { | ||
| ThreadContext.put("key1", "val1"); | ||
| ThreadContext.put("key2", "val2"); | ||
| ThreadContext.put("event.name", "MyEventName"); |
There was a problem hiding this comment.
this line (and its assertion below) found a bug in the Java agent instrumentation
trask
force-pushed
the
unify-log4j2-appender-tests
branch
from
41fbe1f to
98f6d92
Compare
laurit
approved these changes
Oct 9, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #4956